Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict test cache restoration #6128

Closed
wants to merge 1 commit into from
Closed

Restrict test cache restoration #6128

wants to merge 1 commit into from

Conversation

mjjbell
Copy link
Member

@mjjbell mjjbell commented Sep 21, 2021

Issue

There is currently no way to invalidate the cache (actions/cache#2), so master won't pass CI if a breaking change has been made to the binary data formats.

Fix this by only restoring test cache from the same commit SHA.

Tasklist

Requirements / Relations

There is currently no way to invalidate the cache, so master won't pass CI if a breaking change has been made to the binary data formats.

Fix this by only restoring from the same commit SHA.
@mjjbell
Copy link
Member Author

mjjbell commented Sep 21, 2021

Actually, I think this is because osrm-partition and osrm-customize are not being considered when creating the test directories.

@mjjbell
Copy link
Member Author

mjjbell commented Sep 21, 2021

Closed in favour of #6129

@mjjbell mjjbell closed this Sep 21, 2021
@DennisOSRM DennisOSRM deleted the mjjbell-test-cache branch November 6, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant