Remove dummy edges before inplace permutation

[oxidase]

Issue

#5021 (comment) points that the check edge_list.size() < std::numeric_limits<EdgeID>::max() can be placed before the loop, but this check limits number of valid edges by 2^32 - #dummy_edges.

PR implements a removal of dummy edges before a util::inplacePermutation call:
✔️ number of edges is limited by 2^32

❌ an additional iteration over the list of edges, but potentially linearized removal can be faster due to caching

/cc @danpat

Tasklist

• CHANGELOG.md entry (How to write a changelog entry)
• update relevant Wiki pages
• add tests (see testing documentation
• review
• adjust for comments
• cherry pick to release branch

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

[TheMarex]

The reason why we don't remove the dummy edges is that it impacts performance significantly during contraction, since we need the over-allocation for the DynamicGraph to be effective. For example on Bayern the contraction on master needs 504 sec but with this branch 549 sec. If we need to limit the amount of over-allocation we should add a fixed ratio of 30% over-allocation.

[oxidase]

@TheMarex thank you for running performance benchmarks! I think it is enough for now to keep a sanity check to avoid overflows of permutation indexes.

I don't think we need to limit over-allocation but a check before

osrm-backend/src/contractor/graph_contractor.cpp

Line 737 in 4c65210

graph.InsertEdge(edge.source, edge.target, edge.data);

that will stop contraction like

                if (edge_list.size() >= std::numeric_limits<EdgeID>::max())
                {
                    util::Log(logWARNING) << "Too many sortcuts, exiting graph contraction";
                    node_data.Renumber(new_to_old_node_id);
                    RenumberGraph(graph, new_to_old_node_id);
                    return std::move(node_data.is_core);
                }

[TheMarex]

Sanity check looks good. 👍