Avoid using signed integers for edge IDs #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxidase
force-pushed
the
fix/int-overflow
branch
from
f78d8ed to
99d6fd5
Compare
TheMarex
approved these changes
Apr 12, 2018
danpat
reviewed
Apr 12, 2018
| std::vector<EdgeID> old_to_new_edge(edge_list.size(), SPECIAL_EDGEID); | ||
| for (auto node : util::irange<NodeID>(0, number_of_nodes)) | ||
| { | ||
| auto new_first_edge = new_edge_index; | ||
| // move all filled edges | ||
| for (auto edge : GetAdjacentEdgeRange(node)) | ||
| { | ||
| if (new_edge_index == std::numeric_limits<EdgeID>::max()) |
There was a problem hiding this comment.
Can this check be done before we start the loop and fail earlier? We know the size of the edge_list, right? This renumbering shouldn't create more than there was previously....
There was a problem hiding this comment.
yes, the check only prevents overflow of number_of_valid_edges, but you are right old_to_new_edge may be corrupted for dummy edges if new_edge_index overflows below
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PR fixes an integer overflow if number of edges is greater than 2^31 and adds a check for an unsigned integer overflow.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?