Turn restriction (via node) ignored

[hlaw]

http://osrm.at/aEd

The sharp turn at the northwest of the route should not occur, as this should be prohibited by an "only" turn restriction:
http://www.openstreetmap.org/relation/2436379#map=18/22.32655/114.20857

Incidentally the "from" way of the turn restriction is also the "to" way in another turn restriction, similar to the case mentioned in #1041 (closed). Not sure if this is relevant.

Thank you.

[DennisOSRM]

Thanks, will look into it

[hlaw]

I am trying to trace this and found two duplicate tests, this and this, in the same chain of if-else statements in the turn restriction parsing code.

Seems to stem from the refactoring commit 0d9b705 for lines 140 / 142 of ExtractionContainers.cpp. Not sure if this is related to this issue or perhaps the outstanding issues at #1286.

[emiltin]

good catch, looks wrong to me

[DennisOSRM]

Thanks for the pointer into the source code. I was able to remove redundant code and also found another issue where it miscalculated the total number of restrictions (and thus ignored some). Locally this looks much better now:

I am now working on getting the patch into shape and will push it during the day to develop branch. Not sure how to put this edge case into a cucumber test though.

[DennisOSRM]

The fix should be live on the demo site in roughly 10-12 hours from now. Leaving the issue open until we verify it there.

[hlaw]

Looks good, thanks a lot!

[DennisOSRM]

Looking good now.