Problem with only_straight_on restriction

[musuruan]

Wrong routing here:
http://osrm.at/a8x
http://osrm.at/a8y

[matteo-quatrida-zz]

http://osrm.at/a8x -> I've tried to change the relation from "only_straight_on" to "no_left_turn"... let's see if something happens, even if, imho, "only_straight_on" should be the best relation choice.

[floscher]

Another one reported on talk-de: http://osrm.at/a8E
And one from me: http://osrm.at/a8H

The first one seems to misinterpret http://osm.org/relation/2812589 as "don't turn left and don't go straight on".

In the second one http://www.osm.org/relation/4039409 is respected, while http://osm.org/relation/4039408 is not (both are only_straight_on).

[ftrebien]

Maybe this is the same problem: http://osrm.at/a8U
And OSRM times out if one moves the start marker to the middle of the crossing: http://osrm.at/a8T

I'm not getting this with all only_straigh_on restrictions though.

[floscher]

It probably affects all types of turning restrictions (except only_left_turn, which behaved correctly at every junction I checked). For every affected restriction type, it seems that only some of the relations are not respected.

See #1287 for no_u_turn_turn-restrictions and the following examples for some other restriction-types:
http://osrm.at/a95 for no_right_turn
http://osrm.at/a98 for no_left_turn
http://osrm.at/a9a for only_right_turn

[valholl]

I've also found the problem on http://osrm.at/a9I where there are only-straight-on relationships both on the west and the south exits, but only the W one has the problem.

The only difference I can see is that Via Gabriele D'Annunzio is also a member of another only-straight-on relation for this roundabout, which also has this problem toward the other exits, but not toward via D'Annunzio. http://osrm.at/a9K http://osrm.at/a9L

[DennisOSRM]

Thanks all for providing the links. That was really helpful. I have identified an issue in the restrictions parsing code and a patch to the issue should be ready within an hour or two.

[DennisOSRM]

Locally issues seem to be fixed. Will take about 10-11 hours from now until the fix transpires into the demo site.

As an example, one of the reported links looks like this locally:

[floscher]

@DennisOSRM thank you for the fix

@matteo-quatrida in the meantime I've reverted your changes at the roundabout in Italy, because as you said only_straight_on fits better. Besides this, there was also a data issue at this roundabout: The from- and to-way were not connected for http://www.openstreetmap.org/relation/2774049

[matteo-quatrida-zz]

@DennisOSRM +1 (great job!)
@floscher well done, mate! Thank you for the revert and for the correction of the data issue
@musuruan now you can be happier than before! :P
Best regards!

[ftrebien]

@DennisOSRM +1 Thanks a lot!

[floscher]

All examples from above produce the correct routes again on the demo server, except the following two:

• http://osrm.at/a95 with no_right_turn-restriction (http://osm.org/relation/2301448)
• http://osrm.at/a9a with only_right_turn-restriction (http://osm.org/relation/2201698)

[DennisOSRM]

Thanks for checking @floscher. I'll get to this tomorrow.

[floscher]

This issue is still not completely solved. The two routes from my last comment and http://osrm.at/aaD (no_left_turn-restriction http://osm.org/relation/2201695) allow turns that are forbidden by the restrictions.

[floscher]

@DennisOSRM the issue with http://osrm.at/a95, http://osrm.at/a9a and http://osrm.at/aaD still holds