-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
389 add torchvision resnet50 support #390
389 add torchvision resnet50 support #390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
@Warvito This PR does not contain breaking change and will not affect existing tutorials. And it adds support for user provided pre-trained weights for perceptual loss. Could it be merged? |
Hi @yiheng-wang-nv @ericspod , May I know the status of this PR? Can we merge it now. Thanks. |
It's done. I'm not sure if there are any other requirements to merge a PR in this repo (it's my first contribution), may need @ericspod and @Warvito 's confirm, thanks! |
Hi @ericspod , As this PR is necessary for the new MONAI 1.2 bundle and tutorial for Generative AI, I will merge it right now. Thanks. |
Hi @Nic-Ma, no problem. I had suggested an enhancement we can follow up with later if there's need. |
Fixes #389
This PR is used to enable torchvision's version of resnet50 on
PerceptualLoss
.Users can also determine which pretrained weights is used.