Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

389 add torchvision resnet50 support #390

Merged
merged 3 commits into from
May 15, 2023

Conversation

yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented May 11, 2023

Fixes #389

This PR is used to enable torchvision's version of resnet50 on PerceptualLoss.
Users can also determine which pretrained weights is used.

Copy link

@Can-Zhao Can-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@Can-Zhao
Copy link

@Warvito This PR does not contain breaking change and will not affect existing tutorials. And it adds support for user provided pre-trained weights for perceptual loss. Could it be merged?

@Nic-Ma
Copy link
Contributor

Nic-Ma commented May 13, 2023

Hi @yiheng-wang-nv @ericspod ,

May I know the status of this PR? Can we merge it now.

Thanks.

@yiheng-wang-nv
Copy link
Contributor Author

yiheng-wang-nv commented May 13, 2023

Hi @yiheng-wang-nv @ericspod ,

May I know the status of this PR? Can we merge it now.

Thanks.

It's done. I'm not sure if there are any other requirements to merge a PR in this repo (it's my first contribution), may need @ericspod and @Warvito 's confirm, thanks!

@Nic-Ma
Copy link
Contributor

Nic-Ma commented May 15, 2023

Hi @ericspod ,

As this PR is necessary for the new MONAI 1.2 bundle and tutorial for Generative AI, I will merge it right now.
If you have any other comments, let's do it in a following PR.

Thanks.

@Nic-Ma Nic-Ma merged commit f969c24 into Project-MONAI:main May 15, 2023
@ericspod
Copy link
Member

Hi @Nic-Ma, no problem. I had suggested an enhancement we can follow up with later if there's need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Torchvision resnet50 on PerceptualLoss
4 participants