Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3d diffusion model bundle #390

Merged
merged 153 commits into from
May 15, 2023
Merged

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented Apr 24, 2023

Fixes #391 .

Description

Add 3d diffusion model bundle

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Can-Zhao and others added 19 commits April 24, 2023 21:19
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
…ease

enter a commit message to explain why this merge is necessary, #
especially if it merges an updated upstream into a topic branch. # # Lines
starting with '#' will be ignored, and an empty message aborts # the
commit.
Signed-off-by: Can-Zhao <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

This PR can be merged first, but some things need to be updated in the next version:

  1. As I asked, the command to run mgpu training in difussion model may be able to simplify.
  2. Update weights and figures according to the latest changes in pre-trained weights.

cc @Can-Zhao @Nic-Ma @daguangxu

@yiheng-wang-nv
Copy link
Collaborator

/build

1 similar comment
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv force-pushed the ldm3d branch 2 times, most recently from 41fea27 to a08d963 Compare May 15, 2023 11:14
@yiheng-wang-nv
Copy link
Collaborator

/build

Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv mentioned this pull request May 15, 2023
8 tasks
@Can-Zhao
Copy link
Collaborator Author

This PR can be merged first, but some things need to be updated in the next version:

  1. As I asked, the command to run mgpu training in difussion model may be able to simplify.
  2. Update weights and figures according to the latest changes in pre-trained weights.

cc @Can-Zhao @Nic-Ma @daguangxu

Thank you so much Yiheng!

@yiheng-wang-nv
Copy link
Collaborator

The blossom ci test is always failed because of the path issue, I took more time than expected to fix the issue but failed (although my local test is always correct).
To prevent blocking the progress, I will remove the torchscript test on this bundle to avoid the issue
(will add the test back when I continue to work on the PR: #400)

Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv enabled auto-merge (squash) May 15, 2023 14:27
@yiheng-wang-nv yiheng-wang-nv merged commit 0aa0714 into Project-MONAI:dev May 15, 2023
@Can-Zhao Can-Zhao deleted the ldm3d branch May 17, 2023 01:45
yiheng-wang-nv added a commit to yiheng-wang-nv/model-zoo that referenced this pull request Jul 29, 2024
Fixes Project-MONAI#391 .

### Description
Add 3d diffusion model bundle

### Status
**Ready/Work in progress/Hold**

### Please ensure all the checkboxes:
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Codeformat tests passed locally by running `./runtests.sh
--codeformat`.
- [ ] In-line docstrings updated.
- [ ] Update `version` and `changelog` in `metadata.json` if changing an
existing bundle.
- [ ] Please ensure the naming rules in config files meet our
requirements (please refer to: `CONTRIBUTING.md`).
- [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy`
are correct in `metadata.json`.
- [ ] Descriptions should be consistent with the content, such as
`eval_metrics` of the provided weights and TorchScript modules.
- [ ] Files larger than 25MB are excluded and replaced by providing
download links in `large_file.yml`.
- [ ] Avoid using path that contains personal information within config
files (such as use `/home/your_name/` for `"bundle_root"`).

---------

Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: monai-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yiheng Wang <[email protected]>
Co-authored-by: monai-bot <[email protected]>
Co-authored-by: Yiheng Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 3d diffusion model bundle
5 participants