fix displayName for items that are also blocks

[kaduvert]

items which are also blocks lack variations in their spec, leading to wrong displayNames

i assume the correct path to fixing this is to check if the item is also a block and use the displayName from the block variation if applicable

[rom1504]

I think we should rather fix the data, maybe using that same heuristic

[kaduvert]

work smarter, not harder.
it's a 4 line change vs 100s of 1000s of lines of json data

why is this a bad way of fixing the problem?

[kaduvert]

also there is no downside to this because the display names are already wrong, they can either get right or stay wrong
this only affects names that are wrong already

sorry if i'm too pushy but i really don't get why we should go through all of this effort

[rom1504]

From my point of view having 2 different values for displayName of items throughout PrismarineJs is a strict regression

[rom1504]

Also if you apply it on Minecraft data you will realize this heuristic doesn't work for version above 1.13

[kaduvert]

are there even any wrong displayNames in versions above 1.13?

[kaduvert]

after thinking for a moment, you're right.
will look into completing the data with the same heuristic and open a pr in minecraft-data.

[kaduvert]

PrismarineJS/minecraft-data#772