Improve correctness of 1.8 item varieties data

[kaduvert]

No description provided.

[kaduvert]

i abandoned the idea of doing this for all versions, it's just too complicated and i've got no clue about them.
if anyone needs exactly what i need for 1.8, i leave some scripts here which i made for data manipulation / extraction:

// add block variations to item variations if they aren't present
// put in /data/pc
const fs = require('fs')

const versions = [
    '1.7',
    '1.8',
    '1.9',
    '1.10',
    '1.11',
    '1.12'
]

const itemFiles = versions.map((v) => require(`./${v}/items.json`))
const blockFiles = versions.map((v) => require(`./${v}/blocks.json`))

itemFiles.forEach((itemFile, i) => {
    itemFile.forEach(item => {
        const block = blockFiles[i].find(block => item.id === block.id)
        if (!item.variations && block && block.variations) {
            item.variations = block.variations
        }
    })
})

itemFiles.forEach((itemFile, i) => {
    fs.writeFileSync(`./${versions[i]}/items.json`, JSON.stringify(itemFile))
})

// spawn egg name extraction
// put in /data/pc/${version}
const entityFile = require(`./entities.json`)

const metadatas = []

entityFile.sort((a, b) => a.internalId - b.internalId).forEach((entity) => {
    metadatas.push({
        metadata: entity.internalId,
        displayName: 'Spawn ' + entity.displayName
    })
})

console.log(metadatas)

[kaduvert]

i removed the flower pot item varieties because they don't exist; the data was faulty

[rom1504]

why was this removed ?

[rom1504]

looks reasonable except for the flower pot

[kaduvert]

i answered that in the comment above...: #772 (comment)

as you're probably not willing to verify yourself, look: https://www.youtube.com/watch?v=tWyohVt3zZo

[rom1504]

ok