[WIP] Kick client when he is using the wrong version of the client, fix #209 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
checking for the socket existence is useful because of https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/server.js#L41 The broken test is just #194 |
|
Fix crashes when connecting with the wrong version first (for example https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/datatypes/numeric.js#L27 can crash, see https://nodejs.org/api/buffer.html#buffer_buf_writeuintle_value_offset_bytelength_noassert) |
|
the underlying issue is now fixed, so I think this can now be merged. |
Closed
rom1504
force-pushed
the
kick_client_when_wrong_version
branch
from
41a0890 to
4ae1869
Compare
|
(this will be done better in #234 and shouldn't be merged for now) |
rom1504
force-pushed
the
kick_client_when_wrong_version
branch
from
a0e87c1 to
f59485f
Compare
rom1504
changed the title
rom1504
force-pushed
the
kick_client_when_wrong_version
branch
from
ffb0ec3 to
fdc24cb
Compare
roblabla
added a commit
that referenced
this pull request
Sep 24, 2015
[WIP] Kick client when he is using the wrong version of the client, fix #209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.