New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes when connecting to the proxy with the wrong minecraft version #214

Closed

rom1504 opened this issue Aug 12, 2015 · 1 comment

Member

rom1504 commented Aug 12, 2015

for example this tends to crash https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/datatypes/numeric.js#L27
see https://nodejs.org/api/buffer.html#buffer_buf_writeuintle_value_offset_bytelength_noassert
try/catch should be added to prevent the crash (currently it means anybody can crash the proxy)
Also see #213

rom1504 mentioned this issue

[WIP] Better error handling, also some general cleanup #226

Merged

Member Author

rom1504 commented Sep 2, 2015

Fix seems to be fixed now (I just tried)

rom1504 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment