Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Statistics Callback #3072

Closed
wants to merge 8 commits into from
Closed

Conversation

Chitasa
Copy link
Contributor

@Chitasa Chitasa commented Jun 8, 2023

@Chitasa
Copy link
Contributor Author

Chitasa commented Jun 8, 2023

This shouldn't be merged until the necessary data is brought to mcData. The necessary data being the translation map from achievement category as a number to string and a class to unify this across versions. This requires the mcData part to be done thought.

#1962 (comment)

@Chitasa
Copy link
Contributor Author

Chitasa commented Jun 13, 2023

@Chitasa
Copy link
Contributor Author

Chitasa commented Jun 13, 2023

1.8.8 Tests failing because of PrismarineJS/minecraft-data#714
1.13.2+ Tests failing because we need translation mappings

@Chitasa
Copy link
Contributor Author

Chitasa commented Jun 14, 2023

All the statistics tests are going to be failing :I
Requires features added here: PrismarineJS/minecraft-data#714

Probably need to move mappings out of statistics.js and into minecraft-data

@rom1504
Copy link
Member

rom1504 commented Aug 5, 2023

please finish

@Chitasa
Copy link
Contributor Author

Chitasa commented Aug 5, 2023

On vacation right now, I'll fix these things when I get back

@rom1504
Copy link
Member

rom1504 commented Dec 30, 2023

Please re-open if you want to finish it

@rom1504 rom1504 closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants