Adds requestStatistics() promise. #1962
Conversation
|
|
| module.exports = () => async (bot) => { | ||
| const stats = await bot.requestStatistics() | ||
|
|
||
| assert.strictEqual(typeof stats, 'object') |
There was a problem hiding this comment.
definitely going to need more testing then that stats is an object
|
I refactored the code a bit and left a pr: https://github.com/Kaffidev/mineflayer/pull/1 , also, this is going to need to be abstracted if you look at whats printed in tests, imo the statistics need to be extracted from Burger and brought to mcData, where we can then use them in this pr |
|
You are right, thanks for pr. |
Refactor code a bit
|
test is useless, please fix |
|
This shouldn't be merged until the necessary data is brought to mcData. The necessary data being the translation map from achievement category as a number to string and a class to unify this across versions. This requires the mcData part to be done thought. |
U9G is right, but im busy. |
|
too old, reopen if you want to finish |
Closes #1732
Also adds a test and an example.