Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property reader / writer #348

Merged
merged 39 commits into from
Jan 14, 2025
Merged

Property reader / writer #348

merged 39 commits into from
Jan 14, 2025

Conversation

icui
Copy link
Collaborator

@icui icui commented Dec 26, 2024

Description

Read / write GLL properties. Usage:

  ## databases
  databases:
    mesh-database: "./OUTPUT_FILES/database.bin"
    source-file: "./source.yaml"
    reader:
      properties:
        directory: GLL
        format: ASCII
    writer:
      properties:
        directory: GLL
        format: ASCII

Issue Number

Closes #343 and #344

@lsawade lsawade self-requested a review December 30, 2024 08:51
lsawade
lsawade approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a test should be implemented to check whether reading/writing is done properly, other than that it L Amazing TM!

@icui icui requested a review from Rohit-Kakodkar December 30, 2024 14:12
@icui icui changed the title Issue 343 Property reader / writer Dec 30, 2024
Rohit-Kakodkar
Rohit-Kakodkar requested changes Dec 30, 2024
View reviewed changes
src/specfem2d.cpp Outdated
@@ -163,9 +163,31 @@ void execute(const std::string &parameter_file, const std::string &default_file,
specfem::compute::assembly assembly(
mesh, quadrature, sources, receivers, setup.get_seismogram_types(),
setup.get_t0(), dt, nsteps, max_seismogram_time_step,
setup.get_simulation_type());
setup.get_simulation_type(), true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assign property boolean should come from setup class. If we are planning to set it to true always then we dont need a boolean

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I forgot to change this. Now updated.

@icui icui requested a review from Rohit-Kakodkar December 30, 2024 15:34
@icui icui changed the base branch from issue-307-io to issue-277 December 30, 2024 16:44
@icui icui changed the base branch from issue-277 to issue-307-io December 30, 2024 16:44
@icui icui changed the base branch from issue-307-io to issue-228-anisotropy January 9, 2025 23:28
Rohit-Kakodkar
Rohit-Kakodkar approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we saw these changes as previous PR into issue-343

@icui
Merge pull request #371 from PrincetonUniversity/issue-370
02e4b58 
Refactor reader / writer to IO namespace
@icui icui merged commit d10bdf3 into issue-228-anisotropy Jan 14, 2025
3 checks passed
@icui icui deleted the issue-343 branch January 14, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rohit-Kakodkar Rohit-Kakodkar Rohit-Kakodkar approved these changes

@lsawade lsawade lsawade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icui @lsawade @Rohit-Kakodkar