Define runtime parameters in Python #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsawade
approved these changes
Dec 9, 2024
src/specfem2d.cpp
Outdated
| @@ -95,7 +95,13 @@ void execute(const std::string ¶meter_file, const std::string &default_file, | |||
| // Read parameter file | |||
| // -------------------------------------------------------------- | |||
| auto start_time = std::chrono::system_clock::now(); | |||
| specfem::runtime_configuration::setup setup(parameter_file, default_file); | |||
| specfem::runtime_configuration::setup setup(parameter_file, default_file, | |||
| #ifdef SPECFEMPP_BINDING_PYTHON | |||
There was a problem hiding this comment.
This becomes tough to read IMO. We need to come up with a better way
There was a problem hiding this comment.
This should be changed after we template YAML::Node
There was a problem hiding this comment.
Check comments on setup.hpp
include/parameter_parser/setup.hpp
Outdated
| */ | ||
| setup(const std::string ¶meter_file, const std::string &default_file); | ||
| setup(const std::string ¶meter_file, const std::string &default_file, |
There was a problem hiding this comment.
If we provide 2 constructors.
setup(const std::string ¶meter_file, const std::string &default_file)This gets called by specfem2d.cpp driver codetemplate<typename Dictionary> setup(const Dictionary &Dictionary)this gets called by 1 (function listed above) and by python as setup(pybind::dict)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements runtime configuration and add pip dependencies.
Issue Number
#231
Checklist
Please make sure to check developer documentation on specfem docs.
[] I ran the code through pre-commit to check style
[] My code passes all the integration tests
[] I have added sufficient unittests to test my changes
[] I have added/updated documentation for the changes I am proposing
[] I have updated CMakeLists to ensure my code builds
[] My code builds across all platforms