Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secret block #7882

Merged
merged 43 commits into from
Dec 15, 2022
Merged

Add secret block #7882

merged 43 commits into from
Dec 15, 2022

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Dec 14, 2022 •
edited
Loading

Secret storage blocks are used to persist sensitive information in a secure manner. The backing service that is used for persistence will different between implementation, but each implementation will allow for the reading and writing of secret values.

Included update + delete to match what AWS and GCP has; see prefect-gcp and prefect-aws

Part of #7884

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

ahuang11 and others added 30 commits December 8, 2022 18:07
Add abstract blocks
9eb8457
Add missing logger
0003625
Rename some attrs
eff6421
Fix class
97b4d48
Fix import errors and add logging fn
c8be959
Remove extraneous info
1466bfc
Rm wait util and make abstract methods abstract
df1b7d0
More commit
b769f13
Add database abstract block
0df94b6
Remove offset
922b548
Add execution options
97ced6f
Rename to execution_kwargs
0e09b1a
Isolate job block
6c032e0
Merge branch 'main' of https://github.com/PrefectHQ/prefect into abst…
2b87830 
…ract_blocks
@ahuang11
Merge branch 'main' into abstract_blocks
7a37779
Add tests
84a6739
Merge branch 'abstract_blocks' of https://github.com/PrefectHQ/prefect …
f02ed77 
…into abstract_blocks
Review comments
39f89cd
fix docstring
e147ac5
Extend tests
0a8cd7d
Add database block
6504819
Add database block
a05f719
Merge branch 'abstract_blocks' of https://github.com/PrefectHQ/prefect …
bd0792d 
…into abstract_database_block
Add tests
3298be2
Fix docstring
2fa31b8
Add object storage block
aa9fac6
Update docstrings
283218c
Add tests
5798aaa
Merge branch 'main' of https://github.com/PrefectHQ/prefect into abst…
7822904 
…ract_database_block
Add docstrings
c2c61a0
@ahuang11 ahuang11 requested a review from desertaxle December 14, 2022 01:55
@ahuang11 ahuang11 added the development Tech debt, refactors, CI, tests, and other related work. label Dec 14, 2022
@ahuang11 ahuang11 marked this pull request as ready for review December 14, 2022 04:21
@ahuang11 ahuang11 requested a review from zanieb as a code owner December 14, 2022 04:21
desertaxle
desertaxle requested changes Dec 14, 2022
View reviewed changes
src/prefect/blocks/abstract.py Outdated Show resolved Hide resolved
src/prefect/blocks/abstract.py Outdated Show resolved Hide resolved
src/prefect/blocks/abstract.py Outdated Show resolved Hide resolved
src/prefect/blocks/abstract.py Outdated Show resolved Hide resolved
src/prefect/blocks/abstract.py Outdated Show resolved Hide resolved
src/prefect/blocks/abstract.py Outdated Show resolved Hide resolved
desertaxle
desertaxle approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from abstract_object_storage_block to main December 14, 2022 22:56
@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit 4d53e66
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/639a66d7df45c900086c3517
😎 Deploy Preview https://deploy-preview-7882--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ahuang11 ahuang11 merged commit d326440 into main Dec 15, 2022
@ahuang11 ahuang11 deleted the abstract_secret_storage_block branch December 15, 2022 05:35
github-actions bot pushed a commit to ddelange/prefect that referenced this pull request Dec 15, 2022
@ahuang11 @github-actions
Add secret block (PrefectHQ#7882)
b6927c2
zanieb pushed a commit that referenced this pull request Dec 15, 2022
@ahuang11 @zanieb
Add secret block (#7882)
27d4e67
zanieb pushed a commit that referenced this pull request Dec 15, 2022
@ahuang11 @zanieb
Add secret block (#7882)
b8ebaa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@zanieb zanieb Awaiting requested review from zanieb

Assignees
No one assigned
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahuang11 @desertaxle