Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add SecretManager block #86

Merged
merged 21 commits into from
Dec 20, 2022
Merged

Add SecretManager block #86

merged 21 commits into from
Dec 20, 2022

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Dec 14, 2022

Closes

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@ahuang11 ahuang11 mentioned this pull request Dec 14, 2022
3 tasks
@ahuang11 ahuang11 marked this pull request as ready for review December 20, 2022 00:27
@ahuang11 ahuang11 requested a review from desertaxle as a code owner December 20, 2022 00:27
@ahuang11 ahuang11 changed the title Add secret block Add SecretManager block Dec 20, 2022
prefect_gcp/secret_manager.py Outdated Show resolved Hide resolved
@sync_compatible
async def read_secret(
self,
version_id: Union[str, int] = "latest",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to have the secret version be an attribute on the block, but still default to latest. Also I think we can just accept a string for the version. I can't think of any time that we'd need to do math with the version number, and we can cast it to an integer if that case does come up.

@ahuang11 ahuang11 merged commit 1630c75 into main Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants