This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Fixes inferring project from service account and get credentials from google.auth.default #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicit call auth default
1 task
desertaxle
suggested changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these changes look good, but I don't think that we should add an infer_project
attribute. I included my reasoning below, so let me know what you think.
desertaxle
reviewed
Sep 26, 2022
ahuang11
changed the title
Add infer_project, fix inferring project from service account, and ex…
Fixes inferring project from service account and get credentials from google.auth.default
Sep 26, 2022
Strange that the tests are failing from:
But Prefect has Any thoughts? |
I think I may need to mock out
|
I just tried logging in through It generates a file in: Formatted as follows:
So I actually need to search for both |
desertaxle
approved these changes
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
project
attribute from service account, butproject_id
is the proper attribute.google.auth.default
to get a credentials object if noservice_account*
is specifiedRelevant Issue(s)
I think calling google.auth.default will resolve PrefectHQ/prefect-dbt#56 so the profile.yml can be populated from a credentials object
Checklist