Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix tests from GCP upgrade and support Oauth token profiles #68

Merged
merged 7 commits into from
Sep 30, 2022

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Sep 21, 2022

Summary

New prefect-gcp release caused tests to fail.

Also, if a project is specified in BigQueryTargetConfigs, an error about duplicate keys will be raised because prefect-gcp is automatically inferring the project.

Do not merge until PrefectHQ/prefect-gcp#57 is released

Relevant Issue(s)

Checklist

@ahuang11 ahuang11 changed the title Fix tests from GCP upgrade Fix tests from GCP upgrade and support Oauth token profiles Sep 27, 2022
@ahuang11
Copy link
Contributor Author

Tests failing are expected; should be fixed when PrefectHQ/prefect-gcp#57 is released.

@ahuang11 ahuang11 marked this pull request as ready for review September 28, 2022 23:34
desertaxle
desertaxle previously approved these changes Sep 30, 2022
@desertaxle
Copy link
Member

@ahuang11 Should we update the version pin for prefect-gcp since it seems like this requires the latest version?

@ahuang11 ahuang11 merged commit 2dbaaa6 into main Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants