DNS function #73
Merged
DNS function #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alagoutte
reviewed
Feb 4, 2019
PowerArubaSW/Public/DNS.ps1
Outdated
| Get DNS information. | ||
|
|
||
| .DESCRIPTION | ||
| Get dns information about the device |
alagoutte
reviewed
Feb 4, 2019
PowerArubaSW/Public/DNS.ps1
Outdated
| Set the dns mode to manual. | ||
|
|
||
| .EXAMPLE | ||
| Set-ArubaSWDns -mode Manual -server1 10.0.0.1 -server2 10.0.0.2 -domain powerarubasw.com |
There was a problem hiding this comment.
use example network and example domain name (exemple.org)
alagoutte
reviewed
Feb 4, 2019
|
|
||
| .EXAMPLE | ||
| Set-ArubaSWDns -mode Manual -server1 10.0.0.1 -server2 10.0.0.2 -domain powerarubasw.com | ||
| #> |
There was a problem hiding this comment.
add a description to example
alagoutte
reviewed
Feb 4, 2019
PowerArubaSW/Public/DNS.ps1
Outdated
|
|
||
| .EXAMPLE | ||
| Set-ArubaSWDns -mode Manual | ||
| Set the dns mode to manual. |
There was a problem hiding this comment.
add a example with DHCP mode ?
alagoutte
reviewed
Feb 4, 2019
PowerArubaSW/Public/DNS.ps1
Outdated
|
|
||
| $url = "rest/v4/dns" | ||
|
|
||
| $conf = new-Object -TypeName PSObject |
alagoutte
reviewed
Feb 4, 2019
PowerArubaSW/Public/DNS.ps1
Outdated
| $conf | add-member -name "dns_config_mode" -membertype NoteProperty -Value $mode_status | ||
|
|
||
|
|
||
| if ( $PsBoundParameters.ContainsKey('server1') -and $PsBoundParameters.ContainsKey('server2') ) |
There was a problem hiding this comment.
really needed ? the other case don't work ?
There was a problem hiding this comment.
can look here i think it is no needed...
alagoutte
reviewed
Feb 4, 2019
PowerArubaSW/Public/DNS.ps1
Outdated
| [Parameter (Mandatory=$false)] | ||
| [string]$server2, | ||
| [Parameter (Mandatory=$false)] | ||
| [array]$domain |
There was a problem hiding this comment.
May be set it is a array of string ?
alagoutte
reviewed
Feb 4, 2019
|
|
||
| .EXAMPLE | ||
| Remove-ArubaSWDns -server1 none -server2 none -domain none | ||
| #> |
There was a problem hiding this comment.
and it is the same example...
alagoutte
reviewed
Feb 4, 2019
PowerArubaSW/Public/DNS.ps1
Outdated
| [ValidateSet ("DHCP", "Manual")] | ||
| [string]$mode, | ||
| [Parameter (Mandatory=$false)] | ||
| [string]$server1, |
alagoutte
reviewed
Feb 4, 2019
| [array]$domain, | ||
| [Parameter(Mandatory = $false)] | ||
| [switch]$noconfirm | ||
| ) |
There was a problem hiding this comment.
With don't remove ALL stuff and use Set- for unconfigured if needed...
added 2 commits
February 6, 2019 09:50
alagoutte
reviewed
Feb 7, 2019
alagoutte
added a commit
to alagoutte/PowerArubaSW
that referenced
this pull request
Feb 20, 2019
4 new cmdlets * Support of PowerShell (Core) 6 (tested on Linux/Ubuntu and MacOS) (PowerAruba#74) * new parameter (-SkipCertificateCheck) when want to connect using HTTPS to unsecure switch (with no valid certificate) (PowerAruba#74) * Adding DNS support (Get/Set/Remove DNS server and domain names)( PowerAruba#72 PowerAruba#73) * Fix using Get-ArubaSWSystemStatus with VSF/Stacked Switch (PowerAruba#75)
alagoutte
added a commit
to alagoutte/PowerArubaSW
that referenced
this pull request
Feb 21, 2019
4 new cmdlets * Support of PowerShell (Core) 6 (tested on Linux/Ubuntu and MacOS) (PowerAruba#74) * new parameter (-SkipCertificateCheck) when want to connect using HTTPS to unsecure switch (with no valid certificate) (PowerAruba#74) * Adding DNS support (Get/Set/Remove DNS server and domain names)( PowerAruba#72 PowerAruba#73) * Fix using Get-ArubaSWSystemStatus with VSF/Stacked Switch (PowerAruba#75)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.