Add test for DNS function #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alagoutte
reviewed
Feb 4, 2019
Tests/integration/DNS.Tests.ps1
Outdated
|
|
||
| Describe "Set-ArubaSWDns" { | ||
| It "Set ArubaSWDns ip server 1" { | ||
| Set-ArubaSWDns -mode Manual -server1 10.44.1.1 |
There was a problem hiding this comment.
use public DNS (Google, Cloudflare, Quad9) or private example network
alagoutte
reviewed
Feb 4, 2019
Tests/integration/DNS.Tests.ps1
Outdated
| } | ||
|
|
||
| It "Set ArubaSWDns dns domain names" { | ||
| Set-ArubaSWDns -mode Manual -server1 10.44.1.1 -server2 8.8.8.8 -domain test,tttt |
There was a problem hiding this comment.
Set example domain name (example.org, example.com...)
alagoutte
reviewed
Feb 4, 2019
Tests/integration/DNS.Tests.ps1
Outdated
| It "Set ArubaSWDns dns domain names" { | ||
| Set-ArubaSWDns -mode Manual -server1 10.44.1.1 -server2 8.8.8.8 -domain test,tttt | ||
| $dns = Get-ArubaSWDns | ||
| $dns.dns_domain_names | Should be "test,tttt" |
There was a problem hiding this comment.
check also server1/server2 dns ?
alagoutte
reviewed
Feb 4, 2019
Tests/integration/DNS.Tests.ps1
Outdated
| It "Set ArubaSWDns ip server 1" { | ||
| Set-ArubaSWDns -mode Manual -server1 10.44.1.1 | ||
| $dns = Get-ArubaSWDns | ||
| $dns.server_1.octets | Should be "10.44.1.1" |
alagoutte
reviewed
Feb 4, 2019
| Remove-ArubaSWDns -mode Manual -server1 none -server2 none | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
add a example with DHCP mode ?
alagoutte
reviewed
Feb 7, 2019
Tests/integration/DNS.Tests.ps1
Outdated
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
|
|
||
| ../common.ps1 |
alagoutte
reviewed
Feb 7, 2019
Tests/integration/DNS.Tests.ps1
Outdated
|
|
||
| ../common.ps1 | ||
|
|
||
| $mysecpassword = ConvertTo-SecureString $password -AsPlainText -Force |
There was a problem hiding this comment.
no needed.. (look other file)
alagoutte
force-pushed
the
test-dns
branch
2 times, most recently
from
4844ef9 to
f7978b4
Compare
Cloudflare DNS (1.1.1.1) and Google DNS (8.8.8.8)
Check the .version for DNS server and change also it is NullOrEmpty when not configured
alagoutte
added a commit
to alagoutte/PowerArubaSW
that referenced
this pull request
Feb 20, 2019
4 new cmdlets * Support of PowerShell (Core) 6 (tested on Linux/Ubuntu and MacOS) (PowerAruba#74) * new parameter (-SkipCertificateCheck) when want to connect using HTTPS to unsecure switch (with no valid certificate) (PowerAruba#74) * Adding DNS support (Get/Set/Remove DNS server and domain names)( PowerAruba#72 PowerAruba#73) * Fix using Get-ArubaSWSystemStatus with VSF/Stacked Switch (PowerAruba#75)
alagoutte
added a commit
to alagoutte/PowerArubaSW
that referenced
this pull request
Feb 21, 2019
4 new cmdlets * Support of PowerShell (Core) 6 (tested on Linux/Ubuntu and MacOS) (PowerAruba#74) * new parameter (-SkipCertificateCheck) when want to connect using HTTPS to unsecure switch (with no valid certificate) (PowerAruba#74) * Adding DNS support (Get/Set/Remove DNS server and domain names)( PowerAruba#72 PowerAruba#73) * Fix using Get-ArubaSWSystemStatus with VSF/Stacked Switch (PowerAruba#75)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.