Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up post-migration of invite signup #3353

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Clean-up post-migration of invite signup #3353

merged 2 commits into from
Feb 24, 2021

Conversation

paolodamico
Copy link
Contributor

@paolodamico paolodamico commented Feb 16, 2021 •
edited
Loading

Changes

Removes legacy code no longer used with the introduction of the migration of invite signup to React (#3300 & #2734).

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@paolodamico paolodamico requested a review from Twixes February 16, 2021 14:22
@timgl timgl temporarily deployed to posthog-org-signup-reac-h6m5fx February 16, 2021 14:27 Inactive
@paolodamico paolodamico changed the title Org signup react iii Clean-up post-migration of invite signup Feb 16, 2021
@Twixes Twixes temporarily deployed to posthog-org-signup-reac-h6m5fx February 17, 2021 01:55 Inactive
@paolodamico
Copy link
Contributor Author

Thanks for the review @Twixes! This will need a rebase before merging and we need to get #3300 in first, I'll handle it, just documenting it for any bystanders.

@Twixes Twixes mentioned this pull request Feb 17, 2021
Closed
Base automatically changed from org-signup-react-II to master February 19, 2021 22:53
@paolodamico paolodamico merged commit 64bbc92 into master Feb 24, 2021
@paolodamico paolodamico deleted the org-signup-react-III branch February 24, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolodamico @Twixes @timgl