Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate team invite signup to React - Part I (Backend) #2734

Merged
merged 20 commits into from
Feb 11, 2021
Merged

Conversation

paolodamico
Copy link
Contributor

@paolodamico paolodamico commented Dec 10, 2020

Changes

This PR lays the ground work on the backend to migrate the team signups (when a team member signs up to an existing organization) endpoint to React & DRF. Among other things, we intend to simplify these flows & reduce tech debt, plus improve the overall UX (and therefore increase internal referrals). Every new functionality includes applicable functional and unit tests.

A follow-up PR will implement the frontend stuff for this PR, plus remove all the legacy code.

Details:

  • Migrates all relevant endpoints to accept invites to DRF which now validates everything via an API request.
  • Allows to pre-validate invites so that the user doesn't have to re-enter information we already have.
  • Makes use of the recently introduced standardized event usage instrumentation.
    • Fixes an instrumentation bug on how some extra attributes were reported on signup-related events.
  • Adds back-end support to process invite signups with social auth.
  • Renames all references to company_name to the less confusing organization_name.
  • Introduces .active_invites property on organization objects to filter only active invites.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests. Not applicable.
  • Cypress end-to-end tests. Not applicable.

@timgl timgl temporarily deployed to posthog-org-signup-reac-rjrpmc December 10, 2020 18:41 Inactive
@timgl timgl temporarily deployed to posthog-org-signup-reac-rjrpmc December 10, 2020 19:25 Inactive
@timgl timgl temporarily deployed to posthog-org-signup-reac-rjrpmc December 10, 2020 19:28 Inactive
@timgl timgl temporarily deployed to posthog-org-signup-reac-rjrpmc December 10, 2020 19:58 Inactive
@timgl timgl temporarily deployed to posthog-org-signup-reac-rjrpmc December 10, 2020 23:14 Inactive
@paolodamico paolodamico changed the title Migrate team invite signup to React Migrate team invite signup to React - Part I (Backend) Feb 10, 2021
@paolodamico paolodamico marked this pull request as ready for review February 10, 2021 11:50
@paolodamico paolodamico requested a review from Twixes February 10, 2021 11:50
@paolodamico
Copy link
Contributor Author

Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things seem proper

posthog/utils.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants