-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate team invite signup to React - Part I (Backend) #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2021
paolodamico
changed the title
Migrate team invite signup to React
Migrate team invite signup to React - Part I (Backend)
Feb 10, 2021
Cloud tests fixed on https://github.com/PostHog/posthog-production/pull/74 |
Twixes
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things seem proper
This was referenced Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR lays the ground work on the backend to migrate the team signups (when a team member signs up to an existing organization) endpoint to React & DRF. Among other things, we intend to simplify these flows & reduce tech debt, plus improve the overall UX (and therefore increase internal referrals). Every new functionality includes applicable functional and unit tests.
A follow-up PR will implement the frontend stuff for this PR, plus remove all the legacy code.
Details:
company_name
to the less confusingorganization_name
..active_invites
property on organization objects to filter only active invites.Checklist