-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
LGTM thx a ton @Nadarik CC @notwaldorf |
@@ -89,6 +100,7 @@ | |||
|
|||
width: var(--iron-icon-width, 24px); | |||
height: var(--iron-icon-height, 24px); | |||
color: var(--iron-icon-color, inherit); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the color was being given by the fill: currentcolor;
style right above. Is that still needed? Do they work together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notwaldorf, it's not the same.
It works with fill: currentcolor
.
Right now we can colorize icons only via some color inheritance or by applying some global class like .green { color: green }
. But with this change we will be able to apply isolated(encapsulated) custom-styles just like we do it with size (on the L28)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged #39 which adds custom properties for fillColor
and strokeColor
. Is this still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it's not needed anymore! Thx
Closed as already fixed in a different PR |
No description provided.