Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Custom properties for fill and stroke colors #39

Merged
merged 1 commit into from
Oct 19, 2015
Merged

Custom properties for fill and stroke colors #39

merged 1 commit into from
Oct 19, 2015

Conversation

rafaeltavares
Copy link

It will be awesome if we could change the svg stroke colors too.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rafaeltavares
Copy link
Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@rafaeltavares
Copy link
Author

I added the other email to my account.

@googlebot
Copy link

CLAs look good, thanks!

@@ -85,6 +85,7 @@
vertical-align: middle;

fill: currentcolor;
stroke: currentcolor;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it would be best if both of these were custom properties --iron-icon-fill-color and --iron-icon-stroke-color, for example, which would have the default values as currentcolor. That was somebody could customize them after the fact. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the perfect match.
I already committed the changes.

@notwaldorf
Copy link
Contributor

Would you mind squashing your commits into 1, and then I can merge this? Thanks so much!

@rafaeltavares
Copy link
Author

Everything set.
Thanks!

@rafaeltavares rafaeltavares reopened this Oct 6, 2015
@rafaeltavares rafaeltavares changed the title Svg stroke Custom properties for fill and stroke colors Oct 6, 2015
@notwaldorf
Copy link
Contributor

Thanks!

notwaldorf added a commit that referenced this pull request Oct 19, 2015
Custom properties for fill and stroke colors
@notwaldorf notwaldorf merged commit a1029fe into PolymerElements:master Oct 19, 2015
@rafaeltavares rafaeltavares deleted the svg-stroke branch October 20, 2015 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants