-
Notifications
You must be signed in to change notification settings - Fork 39
Custom properties for fill and stroke colors #39
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I added the other email to my account. |
CLAs look good, thanks! |
@@ -85,6 +85,7 @@ | |||
vertical-align: middle; | |||
|
|||
fill: currentcolor; | |||
stroke: currentcolor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it would be best if both of these were custom properties --iron-icon-fill-color
and --iron-icon-stroke-color
, for example, which would have the default values as currentcolor
. That was somebody could customize them after the fact. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be the perfect match.
I already committed the changes.
Would you mind squashing your commits into 1, and then I can merge this? Thanks so much! |
Everything set. |
Thanks! |
Custom properties for fill and stroke colors
It will be awesome if we could change the svg stroke colors too.