Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Allow Pell Grant EFC to be Negative #3218

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

CalebPena
Copy link
Collaborator

@CalebPena CalebPena commented Nov 2, 2023

Fixes #3214

🤖 Generated by Copilot at 3d4257f

Summary

🐛📝🔢

This pull request fixes a bug in the pell_grant_efc variable, which could be negative due to negative contributions from the head or the dependent. It adds a max_ function to the formula in policyengine_us/variables/gov/ed/pell_grant/efc/pell_grant_efc.py and updates the changelog accordingly.

pell_grant_efc
max function prevents bugs_
autumn patch released

Walkthrough

  • Fix bug where pell_grant_efc could be negative by adding max_ function to formula (link)
  • Update changelog entry to indicate patch-level change and bug fix (link)

@CalebPena CalebPena requested a review from MaxGhenis November 2, 2023 21:24
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13c6389) 99.01% compared to head (6796345) 99.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3218   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files        1803     1803           
  Lines       26606    26606           
  Branches      158      158           
=======================================
  Hits        26343    26343           
  Misses        225      225           
  Partials       38       38           
Files Coverage Δ
.../variables/gov/ed/pell_grant/efc/pell_grant_efc.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxGhenis MaxGhenis merged commit 3158a3b into PolicyEngine:master Nov 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If Pell Grant EFC is Negative Return 0
2 participants