Don't Allow Pell Grant EFC to be Negative (#3218)

* floor efc at 0 * add changelog entry --------- Co-authored-by: Caleb <[email protected]> Co-authored-by: Max Ghenis <[email protected]>
PolicyEngine · Nov 4, 2023 · 3158a3b · 3158a3b
1 parent 13c6389
commit 3158a3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -0,0 +1,4 @@
+- bump: patch
+  changes:
+    fixed:
+      - pell_grant_efc now can not be negative
diff --git a/policyengine_us/variables/gov/ed/pell_grant/efc/pell_grant_efc.py b/policyengine_us/variables/gov/ed/pell_grant/efc/pell_grant_efc.py
@@ -22,9 +22,9 @@ def formula(person, period, parameters):
                 where(
                     automatic_zero,
                     0,
-                    head_contribution + dependent_contribution,
+                    max_(0, head_contribution + dependent_contribution),
                 ),
-                head_contribution,
-                where(automatic_zero, 0, head_contribution),
+                max_(0, head_contribution),
+                where(automatic_zero, 0, max_(0, head_contribution)),
             ],
         )