-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update to latest api" #5432
Conversation
That commit is running on my machine. |
The PR in question works fine. Don't revert it just because you didn't read the instructions.
Maybe run the pip command twice. All that was required for me anyway. |
This PR should fix the issues some people are having updating #5434 |
If this does not work "out of the box", it should be kept in a separate branch and tested before it is merged into the main "dev". |
@DBa2016 it does work out of the box for most. Some people were having trouble with pip and the PR i submitted is a workaround, along with a fix for an oversight in the run.sh file It was in a separate branch, and was merged after build check passed and it was approved by multiple people, who had no issues. |
The new API seems to work for most things, but pokemon_optimizer doesn't seem to function anymore. #5439 |
@RedViper9 Mine works well (optimizer). Does your optimizer config contain 'rules' ? |
@solderzzc Yes it does. The issue #5439 is mine. I've been struggling with the new enhancements to the pokemon optimizer since yesterday. Had my bot running on the older version of optimizer.py while I tried to figure it out, but this morning that version fails to work as well. Using the Evolve / Transfer tasks works just fine. I'll try a fresh install tonight. To update I do
Which should overwrite any local changes but leave my config intact. |
The referenced PR seems to produce many issues and needs manual edits (which will show up as diffs later) to be working at all. I suggest reverting it in order to allow further development while it is being tested more thoroughly.
Reverts #5421