Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update to latest api" #5432

Closed
wants to merge 2 commits into from
Closed

Revert "Update to latest api" #5432

wants to merge 2 commits into from

Conversation

DBa2016
Copy link
Contributor

@DBa2016 DBa2016 commented Sep 13, 2016

The referenced PR seems to produce many issues and needs manual edits (which will show up as diffs later) to be working at all. I suggest reverting it in order to allow further development while it is being tested more thoroughly.

Reverts #5421

@solderzzc
Copy link
Contributor

That commit is running on my machine.

@halsafar
Copy link

The PR in question works fine. Don't revert it just because you didn't read the instructions.

rm -rf src/
source bin/activate
pip install --upgrade -r requirements.txt
(let it switch repo when it asks if it asks).

Maybe run the pip command twice.

All that was required for me anyway.

@joelgreen
Copy link
Contributor

This PR should fix the issues some people are having updating #5434

@DBa2016
Copy link
Contributor Author

DBa2016 commented Sep 13, 2016

If this does not work "out of the box", it should be kept in a separate branch and tested before it is merged into the main "dev".

@joelgreen
Copy link
Contributor

joelgreen commented Sep 13, 2016

@DBa2016 it does work out of the box for most. Some people were having trouble with pip and the PR i submitted is a workaround, along with a fix for an oversight in the run.sh file

It was in a separate branch, and was merged after build check passed and it was approved by multiple people, who had no issues.

@RedViper9
Copy link
Contributor

The new API seems to work for most things, but pokemon_optimizer doesn't seem to function anymore. #5439

@solderzzc
Copy link
Contributor

solderzzc commented Sep 13, 2016

@RedViper9 Mine works well (optimizer). Does your optimizer config contain 'rules' ?

@RedViper9
Copy link
Contributor

@solderzzc Yes it does. The issue #5439 is mine. I've been struggling with the new enhancements to the pokemon optimizer since yesterday. Had my bot running on the older version of optimizer.py while I tried to figure it out, but this morning that version fails to work as well. Using the Evolve / Transfer tasks works just fine.

I'll try a fresh install tonight.

To update I do

git fetch --all
git reset --hard origin/dev
git pull origin dev

Which should overwrite any local changes but leave my config intact.

@DBa2016 DBa2016 closed this Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants