Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest api #5421

Merged
merged 4 commits into from
Sep 13, 2016
Merged

Update to latest api #5421

merged 4 commits into from
Sep 13, 2016

Conversation

joelgreen
Copy link
Contributor

@joelgreen joelgreen commented Sep 13, 2016

Short Description:

Updating to latest api at https://github.com/pogodevorg/pgoapi

Signature is now generated by the api instead of the bot, device data is still passed in from bot
Latest protos should support buddy system

@joelgreen joelgreen mentioned this pull request Sep 13, 2016
@@ -64,7 +64,7 @@
try:
import pkg_resources
pgoapi_version = pkg_resources.get_distribution("pgoapi").version
if pgoapi_version < '1.1.8':
if pgoapi_version != '1.1.6':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help me understand... you are suggesting to change the API version requirements from 1.1.8 to 1.1.6?... Does not sound right to me.

Copy link
Contributor Author

@joelgreen joelgreen Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DBa2016 The bot was using my api fork at https://github.com/joelgreen/pgoapi which i incremented the version number, however since switching the changes i made have become obsolete. I'm suggesting we switch back to the main branch which is now about 30 commits ahead. For some reason they never incremented the version number.

@solderzzc
Copy link
Contributor

solderzzc commented Sep 13, 2016

👍

Approved with PullApprove

@joelgreen joelgreen merged commit a630689 into dev Sep 13, 2016
@joelgreen joelgreen deleted the latest-api branch September 13, 2016 17:30
@crvfts
Copy link
Contributor

crvfts commented Sep 13, 2016

how do we get around "The plan is to install the git repository https://github.com/pogodevorg/pgoapi.git/" ? I deleted /python27/src/pgoapi but still get this message.

@javajohnHub
Copy link
Contributor

Bot wont start after merge

@joelgreen
Copy link
Contributor Author

joelgreen commented Sep 13, 2016

sudo pip install -r requirements.txt --upgrade
If you're having trouble updating requirements try removing the -e in requirements.txt
-e git+https://github.com/pogodevorg/pgoapi.git/@5e550f656b318227f021801c796b8a80ad917b93#egg=pgoapi
to
git+https://github.com/pogodevorg/pgoapi.git/@5e550f656b318227f021801c796b8a80ad917b93#egg=pgoapi

You will also have to confirm to switch, and you may need to run it twice since pip has some issues with the repo cloning.

@DBa2016
Copy link
Contributor

DBa2016 commented Sep 13, 2016

errr, can we revert this PR and you fix it so it can be run without manipulating? I understand this is the "dev" branch but no PR should be breaking it.

@joelgreen
Copy link
Contributor Author

@DBa2016 its not broken its just a bug with pip for some people

solderzzc pushed a commit that referenced this pull request Sep 15, 2016
* Revert "Update to latest api"

* * added option to specify max CP for Pokemons to catch
* added option to specify desired fast/charged moves for Pokemons to
* catch

* - added example for charged_attack

* Revert "Revert "Update to latest api""

This reverts commit 15193e1.

* Revert "Update to latest api (#5421)"

This reverts commit a630689.

* Revert "Revert "Update to latest api (#5421)""

This reverts commit 82ec8e6.

* fixes on catch_below_cp logic

* Update pokemon_catch_worker.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants