-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest api #5421
Update to latest api #5421
Conversation
@@ -64,7 +64,7 @@ | |||
try: | |||
import pkg_resources | |||
pgoapi_version = pkg_resources.get_distribution("pgoapi").version | |||
if pgoapi_version < '1.1.8': | |||
if pgoapi_version != '1.1.6': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please help me understand... you are suggesting to change the API version requirements from 1.1.8 to 1.1.6?... Does not sound right to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DBa2016 The bot was using my api fork at https://github.com/joelgreen/pgoapi which i incremented the version number, however since switching the changes i made have become obsolete. I'm suggesting we switch back to the main branch which is now about 30 commits ahead. For some reason they never incremented the version number.
how do we get around "The plan is to install the git repository https://github.com/pogodevorg/pgoapi.git/" ? I deleted /python27/src/pgoapi but still get this message. |
Bot wont start after merge |
You will also have to confirm to switch, and you may need to run it twice since pip has some issues with the repo cloning. |
errr, can we revert this PR and you fix it so it can be run without manipulating? I understand this is the "dev" branch but no PR should be breaking it. |
@DBa2016 its not broken its just a bug with pip for some people |
* Revert "Update to latest api" * * added option to specify max CP for Pokemons to catch * added option to specify desired fast/charged moves for Pokemons to * catch * - added example for charged_attack * Revert "Revert "Update to latest api"" This reverts commit 15193e1. * Revert "Update to latest api (#5421)" This reverts commit a630689. * Revert "Revert "Update to latest api (#5421)"" This reverts commit 82ec8e6. * fixes on catch_below_cp logic * Update pokemon_catch_worker.py
Short Description:
Updating to latest api at https://github.com/pogodevorg/pgoapi
Signature is now generated by the api instead of the bot, device data is still passed in from bot
Latest protos should support buddy system