-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dommaschk potentials implemented in JAX #483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 94.96% 94.71% -0.25%
==========================================
Files 83 86 +3
Lines 21012 21198 +186
==========================================
+ Hits 19954 20078 +124
- Misses 1058 1120 +62
|
…sure summations are only being used where they are valid
…lculate number of modes
…r any range of m,l >=0
…calar(jnp.array(B0)) returning error
…andle integer coordinates
…e to xla backend compile?
… This does make the fitting much slower though
f0uriest
previously approved these changes
Mar 7, 2024
f0uriest
previously approved these changes
Mar 11, 2024
dpanici
requested review from
kianorr,
YigitElma and
rahulgaur104
and removed request for
rahulgaur104,
ddudt,
kianorr and
YigitElma
March 12, 2024 14:30
ddudt
previously approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but check docstring formatting
ddudt
previously approved these changes
Mar 13, 2024
f0uriest
approved these changes
Mar 13, 2024
ddudt
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Dommaschk 1986 paper, implementing general Dommaschk potentials in JAX so can automatically differentiate to find the field
TODO:
Pushing off improving the fit logic to #928 , this PR has been good to go for a while now, might as well get it in.