Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dommaschk potential fitting #928

Open
1 task done
dpanici opened this issue Mar 6, 2024 · 1 comment
Open
1 task done

Improve Dommaschk potential fitting #928

dpanici opened this issue Mar 6, 2024 · 1 comment
Assignees
Labels
P2 Medium Priority, not urgent but should be on the near-term agend

Comments

@dpanici
Copy link
Collaborator

dpanici commented Mar 6, 2024

  • The logic when creating the basis modes for fitting a Dommaschk potential to a given magnetic field is cumbersome, especially when the field is stellarator symmetric, involving nested for loops and conditionals. It would be better to re-arrange things and refactor to use numpy where statements instead.

  • Further, it might be that if the field periodicity is known, that only ms which are multiples of NFP are needed, which should also be enforced in the fitting. Currently the fitting includes every l,m up to the specified max l and m.

@dpanici dpanici self-assigned this Mar 6, 2024
@dpanici dpanici changed the title Improve logic for Dommaschk potential fitting when it is known the field is stellarator symmetric Improve logic for Dommaschk potential fitting Mar 6, 2024
@dpanici dpanici added the low priority Nice to have, but not needed right away label Jun 25, 2024
@dpanici dpanici added P2 Medium Priority, not urgent but should be on the near-term agend and removed low priority Nice to have, but not needed right away labels Nov 11, 2024
@dpanici
Copy link
Collaborator Author

dpanici commented Nov 18, 2024

# TODO: add basis argument for if passed-in field or callable

@dpanici dpanici changed the title Improve logic for Dommaschk potential fitting Improve Dommaschk potential fitting Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium Priority, not urgent but should be on the near-term agend
Projects
None yet
Development

No branches or pull requests

1 participant