New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `nan` in reverse mode gradient caused by `rotation_matrix` #1457

Draft

dpanici wants to merge 3 commits into master from dp/nangrad-bdryerr-coils

Draft

Fix `nan` in reverse mode gradient caused by `rotation_matrix` #1457

Merge branch 'master' into dp/nangrad-bdryerr-coils

Codecov / codecov/patch failed Dec 12, 2024 in 1s

21.73% of diff hit (target 95.56%)

View this Pull Request on Codecov

21.73% of diff hit (target 95.56%)

Annotations

Check warning on line 217 in desc/compute/_curve.py

codecov / codecov/patch

desc/compute/_curve.py#L217

Added line #L217 was not covered by tests

Check warning on line 255 in desc/compute/_curve.py

codecov / codecov/patch

desc/compute/_curve.py#L255

Added line #L255 was not covered by tests

Check warning on line 298 in desc/compute/_curve.py

codecov / codecov/patch

desc/compute/_curve.py#L298

Added line #L298 was not covered by tests

Check warning on line 348 in desc/compute/_curve.py

codecov / codecov/patch

desc/compute/_curve.py#L348

Added line #L348 was not covered by tests

Check warning on line 61 in desc/compute/geom_utils.py

codecov / codecov/patch

desc/compute/geom_utils.py#L61

Added line #L61 was not covered by tests

Check warning on line 96 in desc/compute/geom_utils.py

codecov / codecov/patch

desc/compute/geom_utils.py#L84-L96

Added lines #L84 - L96 were not covered by tests

View more details on Codecov