Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some examples do not run as intended in desc/examples #1185

Closed
dpanici opened this issue Aug 13, 2024 · 2 comments · Fixed by #1406
Closed

Some examples do not run as intended in desc/examples #1185

dpanici opened this issue Aug 13, 2024 · 2 comments · Fixed by #1406
Labels
P3 Highest Priority, someone is/should be actively working on this testing Adding a new test or fixing an existing one

Comments

@dpanici
Copy link
Collaborator

dpanici commented Aug 13, 2024

  • Should we add the examples to the CI, to run them and ensure the results are nested and match some reference result?
    • Or add a flag for test_examples we can add to a PR like test_jax, required to merge BUT does not run automatically so must be added each time.
@dpanici dpanici added the testing Adding a new test or fixing an existing one label Aug 13, 2024
@dpanici
Copy link
Collaborator Author

dpanici commented Nov 11, 2024

Scheduled issue/action to check these

@dpanici dpanici added the P3 Highest Priority, someone is/should be actively working on this label Nov 11, 2024
@dpanici
Copy link
Collaborator Author

dpanici commented Nov 11, 2024

related to #1186

@f0uriest f0uriest mentioned this issue Nov 21, 2024
Merged
f0uriest added a commit that referenced this issue Dec 11, 2024
@f0uriest
Update equilibria in desc.examples (#1406)
8804180 
Resolves #1185 
Resolves #1186 

Re-ran them all and manually verified they look good by eye and the
usual metrics (low force error etc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Highest Priority, someone is/should be actively working on this testing Adding a new test or fixing an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update equilibria in desc.examples PlasmaControl/DESC
1 participant
@dpanici