Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check + Update old notebooks on a recurring basis #1186

Closed
2 tasks
dpanici opened this issue Aug 13, 2024 · 1 comment · Fixed by #1406
Closed
2 tasks

Check + Update old notebooks on a recurring basis #1186

dpanici opened this issue Aug 13, 2024 · 1 comment · Fixed by #1406
Assignees
@f0uriest @dpanici
Labels
P3 Highest Priority, someone is/should be actively working on this testing Adding a new test or fixing an existing one

Comments

@dpanici
Copy link
Collaborator

dpanici commented Aug 13, 2024

  • make a recurring issue to check notebooks for syntax/up-to-dateness with master and current API
  • add assert statements to notebooks for correctness so nbtests also check result correctness
@dpanici dpanici added the testing Adding a new test or fixing an existing one label Aug 13, 2024
@dpanici dpanici self-assigned this Aug 13, 2024
@dpanici dpanici added the P3 Highest Priority, someone is/should be actively working on this label Nov 11, 2024
@dpanici dpanici mentioned this issue Nov 11, 2024
Closed
@dpanici
Copy link
Collaborator Author

dpanici commented Dec 9, 2024

#1425

@f0uriest f0uriest mentioned this issue Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f0uriest f0uriest

@dpanici dpanici

Labels
P3 Highest Priority, someone is/should be actively working on this testing Adding a new test or fixing an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update equilibria in desc.examples PlasmaControl/DESC
2 participants
@f0uriest @dpanici