Rewrite data fetch using async/await. Refs #25 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Jaenisch <[email protected]>
fluffy-critter
requested changes
Apr 8, 2021
There was a problem hiding this comment.
I was thinking that the whole thing could just avoid using explicit promises and remove the getData URL entirely, and the main flow would be like:
let response = await window.fetch(url);
if (response.status < 200 || response.status >= 300) {
throw "data fetch failed";
}
// do the rest of the stuff to response.jsonlike, the only reason getData existed is to support the XHR polyfill.
Signed-off-by: André Jaenisch <[email protected]>
Signed-off-by: André Jaenisch <[email protected]>
fluffy-critter
requested changes
Apr 8, 2021
| }; | ||
|
|
||
| json.children.forEach(function(child) { | ||
| // This seem to push the reaction into either comments or collects |
There was a problem hiding this comment.
Make this comment "put the reaction into its appropriate destination"
There was a problem hiding this comment.
I've added that comment, because I wasn't quite sure what's going on there.
Feels a bit dirty to have the store point to the respective object in memory …
=> Another issue?
There was a problem hiding this comment.
There is nothing dirty about that pattern. It's simple and straightforward and efficient.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Jaenisch [email protected]
I wasn't sure, how far you want to have async/await applied.
(See also What Color is Your Function?