Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize Javascript #25

Closed
fluffy-critter opened this issue Apr 7, 2021 · 2 comments
Closed

Modernize Javascript #25

fluffy-critter opened this issue Apr 7, 2021 · 2 comments

Comments

@fluffy-critter
Copy link
Collaborator

  1. A lot of strings can be simplified using template literals
  2. There's no need for the fetch() polyfill anymore
  3. It's probably safe to do native async/await on fetch()
@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Apr 7, 2021

I proposed #29 as a possible solution (note, that merging it won't close this issue).
async/await is not part of it.

Ryuno-Ki added a commit to Ryuno-Ki/webmention.js that referenced this issue Apr 8, 2021
@Ryuno-Ki
Rewrite data fetch using async/await. Refs PlaidWeb#25
1c2af54 
Signed-off-by: André Jaenisch <[email protected]>
Ryuno-Ki added a commit to Ryuno-Ki/webmention.js that referenced this issue Apr 8, 2021
@Ryuno-Ki
Rewrite data fetch using async/await. Refs PlaidWeb#25
9975c25 
Signed-off-by: André Jaenisch <[email protected]>
@Ryuno-Ki Ryuno-Ki mentioned this issue Apr 8, 2021
Open
fluffy-critter added a commit that referenced this issue Apr 8, 2021
@fluffy-critter
Merge pull request #32 from Ryuno-Ki/async-await
08ae4ab 
Rewrite data fetch using async/await. Refs #25
@fluffy-critter
Copy link
Collaborator Author

Fixed in #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fluffy-critter @Ryuno-Ki