-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ameliorate English strings #65
Ameliorate English strings #65
Conversation
@LinkBoi00 Can you send screenshot of the home screen with these changes ? |
|
There should be Install ROM/Install Patches (Modify ROM) |
Is something like: |
@md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now |
Also corrected a wrong capitalization in "Enable dmesg logging after flash" (F was capital) |
@manjotsidhu Here's the final look of the home screen, adressing @md-raza 's feedback
So @manjotsidhu here's the final look of the home screen |
Actually the previous strings were made by @AndroiableDroid and he specifically made it to be in slang language. I don't know which is better. Would be needing community's feedback on this. |
The thing is, that the language was inconsistent (for example, wrong capitalizations) and sometimes it was really not understandable, but sure, no problem. Thanks |
Lets discuss on #66 |
Looks like we have got sufficient feedback on it. @LinkBoi00 just need to change Advanced Card string to "More options for advanced users" and then we are good to go. |
@manjotsidhu LGTM |
Alright, will do soon, thanks |
It looks a bit empty w/o the second "more", maybe I will have to put something else in its place |
@manjotsidhu Force pushed again, addressing your feedback |
Also, I changed this string: pb_dmverity_chk, since, I think it's more understandable now |
@AndroiableDroid once review for the final time. |
Is this the final homescreen ? |
Almost, there is a small change in Advanced Card string |
Yup " More options for advanced users " suits better |
@LinkBoi00 can you make PR for |
sure |
We Merge Pull Requests Submitted Here After Reviewed By Core Developers
If you are submitting any patches, Tell us a little about it.
Fixes:
Improvements:
Kindly wait for Core Developers to review.
You can join our community on Telegram