Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ameliorate English strings #65

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Ameliorate English strings #65

merged 1 commit into from
Feb 7, 2021

Conversation

LinkBoi00
Copy link
Contributor

@LinkBoi00 LinkBoi00 commented Jan 14, 2021

We Merge Pull Requests Submitted Here After Reviewed By Core Developers

If you are submitting any patches, Tell us a little about it.

Fixes:

  • Doesn't really fix anything in core functionality, it's more of an improvement rather than a fix

Improvements:

  • Makes the recovery look a lot better by using more formal and grammatically correct language

Kindly wait for Core Developers to review.

You can join our community on Telegram

@manjotsidhu
Copy link
Member

@LinkBoi00 Can you send screenshot of the home screen with these changes ?

@LinkBoi00
Copy link
Contributor Author

@LinkBoi00 Can you send screenshot of the home screen with these changes ?

Sure
Screenshot_PBRP_2021-01-15-00-00-50
Screenshot_PBRP_2021-01-15-00-00-55
Screenshot_PBRP_2021-01-15-00-01-02

@LinkBoi00
Copy link
Contributor Author

@LinkBoi00

?

@DelightReza
Copy link
Contributor

@LinkBoi00 Can you send screenshot of the home screen with these changes ?

Sure
Screenshot_PBRP_2021-01-15-00-00-50
Screenshot_PBRP_2021-01-15-00-00-55
Screenshot_PBRP_2021-01-15-00-01-02

There should be Install ROM/Install Patches (Modify ROM)

@LinkBoi00
Copy link
Contributor Author

LinkBoi00 commented Jan 15, 2021

@LinkBoi00 Can you send screenshot of the home screen with these changes ?

Sure
Screenshot_PBRP_2021-01-15-00-00-50
Screenshot_PBRP_2021-01-15-00-00-55
Screenshot_PBRP_2021-01-15-00-01-02

There should be Install ROM/Install Patches (Modify ROM)

Is something like:
Install ROM or make modifications to the installed ROM (in 2 lines) fine?
(Maybe that won't fit, I'll work on it later today)

@LinkBoi00
Copy link
Contributor Author

Screenshot_PBRP_2021-01-15-05-48-07 1

@md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

@LinkBoi00
Copy link
Contributor Author

Also corrected a wrong capitalization in "Enable dmesg logging after flash" (F was capital)

@LinkBoi00
Copy link
Contributor Author

@manjotsidhu Here's the final look of the home screen, adressing @md-raza 's feedback

Screenshot_PBRP_2021-01-15-05-48-07 1

@md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

So @manjotsidhu here's the final look of the home screen

@manjotsidhu
Copy link
Member

Screenshot_PBRP_2021-01-15-05-48-07 1

@md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

Actually the previous strings were made by @AndroiableDroid and he specifically made it to be in slang language. I don't know which is better. Would be needing community's feedback on this.

@LinkBoi00
Copy link
Contributor Author

LinkBoi00 commented Jan 15, 2021

Screenshot_PBRP_2021-01-15-05-48-07 1
@md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

Actually the previous strings were made by @AndroiableDroid and he specifically made it to be in slang language. I don't know which is better. Would be needing community's feedback on this.

The thing is, that the language was inconsistent (for example, wrong capitalizations) and sometimes it was really not understandable, but sure, no problem. Thanks

@manjotsidhu
Copy link
Member

Lets discuss on #66

@manjotsidhu
Copy link
Member

Lets discuss on #66

Looks like we have got sufficient feedback on it. @LinkBoi00 just need to change Advanced Card string to "More options for advanced users" and then we are good to go.

@AndroiableDroid
Copy link
Member

@manjotsidhu LGTM

@LinkBoi00
Copy link
Contributor Author

Lets discuss on #66

Looks like we have got sufficient feedback on it. @LinkBoi00 just need to change Advanced Card string to "More options for advanced users" and then we are good to go.

Alright, will do soon, thanks

@LinkBoi00
Copy link
Contributor Author

It looks a bit empty w/o the second "more", maybe I will have to put something else in its place

@LinkBoi00
Copy link
Contributor Author

@manjotsidhu Force pushed again, addressing your feedback

@LinkBoi00
Copy link
Contributor Author

Also, I changed this string: pb_dmverity_chk, since, I think it's more understandable now

@manjotsidhu
Copy link
Member

@AndroiableDroid once review for the final time.

@imranpopz
Copy link
Member

Screenshot_PBRP_2021-01-15-05-48-07 1
@md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

Actually the previous strings were made by @AndroiableDroid and he specifically made it to be in slang language. I don't know which is better. Would be needing community's feedback on this.

The thing is, that the language was inconsistent (for example, wrong capitalizations) and sometimes it was really not understandable, but sure, no problem. Thanks

Is this the final homescreen ?

@manjotsidhu
Copy link
Member

Almost, there is a small change in Advanced Card string

@imranpopz
Copy link
Member

Almost, there is a small change in Advanced Card string

Yup " More options for advanced users " suits better

@manjotsidhu manjotsidhu merged commit b402d6d into PitchBlackRecoveryProject:android-9.0 Feb 7, 2021
@manjotsidhu
Copy link
Member

@LinkBoi00 can you make PR for android-10.0 branch as well ?

@LinkBoi00
Copy link
Contributor Author

@LinkBoi00 can you make PR for android-10.0 branch as well ?

sure

manjotsidhu pushed a commit that referenced this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants