Use Identify to get image width and height #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I noticed, that the cropping and scaling comments say that the image will be saved as jpg, but instead they save the image in the format of the input image. Is that how it supposed to be or should it be changed to really save the image to jpeg? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the ImageSharpProcessor to use
Identifyto get the image width and height, instead of decoding the complete image.Also the ImageSharp version is updated to 1.0.4. I have seen that the piranha core project has switched to net6.0. The hotfix version 1.0.4 of ImageSharp, which occurs with .net6.0 and decoding pngs