Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom Piranha Manager authorization policy requirements #1692

Merged

Conversation

tedvanderveen
Copy link
Contributor

Currently Piranha Manager requires Claims based authorization to satisfy controller authorization Policies.
This PR allows for a custom delegate to be provided through which policies can be configured so that alternative requirements can be used. For example Role based authorization.

@tidyui
Copy link
Member

tidyui commented Aug 23, 2021

Looks good @tedvanderveen Could you possible add some lines with an example on how to configure the application policies here?

https://github.com/PiranhaCMS/piranha.core.docs/blob/master/src/04.%20Architecture/02.%20Authentication/Index.md

Regards

@jensbrak
Copy link
Contributor

Useful addition and it makes the existing functionality more clean too! Nice!

@tedvanderveen
Copy link
Contributor Author

tedvanderveen commented Aug 26, 2021

Looks good @tedvanderveen Could you possible add some lines with an example on how to configure the application policies here?

https://github.com/PiranhaCMS/piranha.core.docs/blob/master/src/04.%20Architecture/02.%20Authentication/Index.md

Regards

I've added sample of usage: PiranhaCMS/piranha.core.docs@master...tedvanderveen:patch-1

@tedvanderveen
Copy link
Contributor Author

Please allow me to take a second look at this @tidyui. Issue I encounter in my project is the 1-to-1 relation between all the Permissions and Policies.

@tidyui tidyui merged commit 2e7e5d9 into PiranhaCMS:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants