Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pomelo.EntityFrameworkCore.MySql #1646

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

aatmmr
Copy link

@aatmmr aatmmr commented Jun 15, 2021

Changes:

  • Updates MySQL references in Data and Identity to Pomelo.EntityFrameworkCore.MySql version 5.0.0
  • Updates DBFactory to include required ServerVersion. The implementation uses the automatic detection of the server version based of the given connection string.

@dnfadmin
Copy link

dnfadmin commented Jun 15, 2021

CLA assistant check
All CLA requirements met.

@tidyui
Copy link
Member

tidyui commented Jun 15, 2021

Looks good! Do we need to update the documentation/templates on how to configure the connection?

@aatmmr
Copy link
Author

aatmmr commented Jun 15, 2021

Yes, there is a slight change how the db connection is set up. I‘ll update the documentation and templates separately.

@tidyui tidyui added this to the Version 9.2 milestone Jun 16, 2021
@tidyui tidyui added the core-ef label Jun 16, 2021
@tidyui
Copy link
Member

tidyui commented Jun 18, 2021

This will be pushed to 10.0 as it will introduce breaking changes to connection setup.

@tidyui tidyui modified the milestones: Version 9.2, Version 10.0 Jun 18, 2021
@tidyui tidyui merged commit 0b258bb into PiranhaCMS:master Oct 8, 2021
@tidyui tidyui changed the title Updating to Pomelo.EntityFrameworkCore.MySql v5.0.0 Update Pomelo.EntityFrameworkCore.MySql Oct 25, 2021
@aatmmr
Copy link
Author

aatmmr commented Oct 26, 2021

The Pomelo team is working on a version with .NET 6 which is currently rc1 so there might by a release ready for Piranha v10.

@tidyui
Copy link
Member

tidyui commented Oct 26, 2021

Yes we just released 10-alpha1 which uses the rc release of pomelo 6. Since it doesn’t look like they’re introducing any breaking API changes it shouldn’t be a problem releasing an update to our mysql package if they release late either!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants