Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hostname with prefix in sitemap #1084

Closed
wants to merge 1 commit into from

Conversation

gyfke
Copy link
Contributor

@gyfke gyfke commented Mar 7, 2020

Fixes #1083

Copy link
Member

@tidyui tidyui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think hostname includes port. Have you tested this on localhost?

@tidyui
Copy link
Member

tidyui commented Mar 28, 2020

I have looked at #1083 and it's a bit more complicated than the above solution. When requesting

http://<hostname>/sitemap.xml

The active site (which will be used to render the sitemap items) will only be the site that matches the hostname. Let's say for example that you have the following sites in your application.

http://<hostname>
http://<hostname>/en

As the code is build now requesting http://<hostname>/sitemap.xml will only give you the items of the first site, when in fact it should return the items of both sites, with the /en added to the links of the second site.

@tidyui tidyui closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Urls in sitemap doesn't consider prefixes
2 participants