Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search only works for root level pages in Page dialog #2000

Closed
zoinkydoink opened this issue May 16, 2023 · 4 comments
Closed

Search only works for root level pages in Page dialog #2000

zoinkydoink opened this issue May 16, 2023 · 4 comments
Assignees
Milestone

Comments

@zoinkydoink
Copy link

I have about 40-60 pages created, they link to each other so when I go to make some text a link to another page, when the selection for page lists comes, and if i type anything in the search, nothing ever comes up, no matter what i type, blank results are the list. (this is for sub pages), if i type 'b' then blog comes up as the first level, but nothing after first level ever shows up

I also opened this issue on SO but havent gotten a response https://stackoverflow.com/questions/76197066/piranha-cms-anchor-link-and-sitemap-question

@tidyui tidyui changed the title linking search, sitemap add anchoring link to toolbar Search only works for root level pages in Page dialog May 23, 2023
@tidyui tidyui added this to the Version 10.4 milestone May 23, 2023
@tidyui
Copy link
Member

tidyui commented May 23, 2023

Confirmed. Will fix this for the next upcoming minor release

@zacpwhite
Copy link
Contributor

@tidyui I will gladly work on resolving this issue.

  • What is the expected output of the page search when nested pages exist?
  • Should the search return the filtered results as a flat list or should it continue to display the parent / child hierarchy?

i.e. When the hierarchy About > Contact exists, when searching with the term 'con', should the result be returned as

  • About
    • Contact

OR

  • Contact

@tidyui
Copy link
Member

tidyui commented Aug 15, 2023

@zacpwhite Sorry, I didn't have time to respond earlier. I'll take a look at the PR and we can take it from there!

Regards

@zacpwhite
Copy link
Contributor

@tidyui no worries! Thanks!

tidyui added a commit that referenced this issue Sep 20, 2023
@tidyui tidyui moved this to Done in Version 10.4 Sep 20, 2023
@tidyui tidyui closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants