BadImport: Add newInstance to BAD_STATIC_IDENTIFIERS
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
force-pushed
the
rossendrijver/badimport-newinstance
branch
from
1d6efed to
26755e1
Compare
Stephan202
approved these changes
Jan 6, 2023
| "", | ||
| "class Test {", | ||
| " private final CompilationTestHelper compilationTestHelper =", | ||
| " // BUG: Diagnostic contains:", |
There was a problem hiding this comment.
Suggested change
| " // BUG: Diagnostic contains:", | |
| " // BUG: Diagnostic contains: CompilationTestHelper.newInstance", |
|
Thanks for the suggestion! Will squash the changes and open a PR! |
rickie
force-pushed
the
rossendrijver/badimport-newinstance
branch
from
26755e1 to
40f116b
Compare
|
Filed google#3703. |
|
Fixed in: google#3703. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now almost have our own version of this check as well. Do we still want to upstream this one? I think it would still be a nice improvement.