BadImport: flag static import of newInstance methods

PicnicSupermarket · Jan 8, 2023 · 40f116b · 40f116b
1 parent 181f991
commit 40f116b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/BadImport.java b/core/src/main/java/com/google/errorprone/bugpatterns/BadImport.java
@@ -82,6 +82,7 @@ public class BadImport extends BugChecker implements ImportTreeMatcher {
           "getDefaultInstance",
           "INSTANCE",
           "newBuilder",
+          "newInstance",
           "of",
           "valueOf");
 

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/BadImportTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/BadImportTest.java
@@ -44,6 +44,23 @@ public void positive_static_simpleCase() {
         .doTest();
   }
 
+  @Test
+  public void positive_identifiers() {
+    compilationTestHelper
+        .addSourceLines(
+            "Test.java",
+            "import static com.google.errorprone.CompilationTestHelper.newInstance;",
+            "import com.google.errorprone.CompilationTestHelper;",
+            "import com.google.errorprone.bugpatterns.BugChecker;",
+            "",
+            "class Test {",
+            "  private final CompilationTestHelper compilationTestHelper =",
+            "      // BUG: Diagnostic contains: CompilationTestHelper.newInstance",
+            "      newInstance(BugChecker.class, getClass());",
+            "}")
+        .doTest();
+  }
+
   @Test
   public void msg() {
     compilationTestHelper