Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the mutation test setup #976

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 14, 2024

See #972 (comment) and pitest/pitest-junit5-plugin#105. This largely reverts #973.

I'll rebase #972 on top of this PR to prove that this fixes things, but one can also run ./run-mutation-tests.sh locally to do the same.

Suggested commit message:

Fix the mutation test setup (#976)

This largely reverts commit dff67fecbceccde17c4839e37c73dc66a9c65c0f,
avoiding the issue described in pitest/pitest-junit5-plugin#105.

This largely reverts commit dff67fe,
avoiding the issue described in pitest/pitest-junit5-plugin#105.
@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label Jan 14, 2024
@Stephan202 Stephan202 added this to the 0.15.0 milestone Jan 14, 2024
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that we detected this early.

@rickie rickie merged commit 09317ab into master Jan 14, 2024
16 checks passed
@rickie rickie deleted the sschroevers/fix-mutation-tests branch January 14, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task not related to code (build, formatting, process, ...)
Development

Successfully merging this pull request may close these issues.

3 participants