Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have ErrorProneRuntimeClasspath ignore non-public types #972

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Have ErrorProneRuntimeClasspath ignore non-public types #972

merged 2 commits into from
Jan 29, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 13, 2024 •
edited
Loading

❗ This PR is on top of #976. ❗

Suggested commit message:

Have `ErrorProneRuntimeClasspath` ignore non-public types (#972)

@Stephan202 Stephan202 added this to the 0.15.0 milestone Jan 13, 2024
@Stephan202 Stephan202 requested a review from rickie January 13, 2024 15:34
@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 3
  • Killed mutants in this change: 14
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.util.ThirdPartyLibrary 3 14

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the sschroevers/error-prone-classpath-fix branch from 4405ef0 to 60e6028 Compare January 13, 2024 16:48
@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 3
  • Killed mutants in this change: 16
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.util.ThirdPartyLibrary 3 16

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 3
  • Killed mutants in this change: 16
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.util.ThirdPartyLibrary 3 16

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the sschroevers/error-prone-classpath-fix branch from 60e6028 to 82b9024 Compare January 13, 2024 20:23
@Stephan202
Copy link
Member Author

Okay, the Pitest analysis now fails. Seems to be due to junit-jupiter-engine dependencies being dropped in #973. Two thoughts:

  1. Would have been nice if CI had caught this, but that's perhaps too expensive to achieve.
  2. I guess I should report this upstream, as it's counter-intuitive that Surefire doesn't require this dependency to be specified explicitly, while Pitest does.

@Stephan202 Stephan202 mentioned this pull request Jan 13, 2024
Open
@Stephan202
Copy link
Member Author

I filed pitest/pitest-junit5-plugin#105. Let's see whether there's a fast response; I can open a PR to revert most of #973 tomorrow.

@Stephan202 Stephan202 mentioned this pull request Jan 14, 2024
Merged
@Stephan202 Stephan202 force-pushed the sschroevers/error-prone-classpath-fix branch from 82b9024 to ce44245 Compare January 14, 2024 12:58
@Stephan202 Stephan202 changed the base branch from master to sschroevers/fix-mutation-tests January 14, 2024 12:58
@Stephan202
Copy link
Member Author

I rebased the branch on top of #976; the build should now pass 👀

@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 3
  • Killed mutants in this change: 16
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.util.ThirdPartyLibrary 3 16

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Base automatically changed from sschroevers/fix-mutation-tests to master January 14, 2024 18:04
@Stephan202 Stephan202 force-pushed the sschroevers/error-prone-classpath-fix branch from ce44245 to 3d0cfd5 Compare January 14, 2024 20:13
@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 3
  • Killed mutants in this change: 16
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.util.ThirdPartyLibrary 3 16

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 mentioned this pull request Jan 21, 2024
Merged
@rickie rickie force-pushed the sschroevers/error-prone-classpath-fix branch from 3d0cfd5 to 5994a5e Compare January 29, 2024 06:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 3
  • Killed mutants in this change: 16
class surviving killed
🧟tech.picnic.errorprone.bugpatterns.util.ThirdPartyLibrary 3 16

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie
rickie approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 🚀

...one-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/util/ThirdPartyLibraryTest.java
ImmutableMap.of(
"GUAVA_PUBLIC",
ImmutableList.class.getCanonicalName(),
"GUAVA_PRIVATE",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on how you look at it, but strictly speaking this type is not private, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it's package-private, but here I meant private-to-the-library/implementation.

@rickie rickie merged commit 5f80fb5 into master Jan 29, 2024
16 checks passed
@rickie rickie deleted the sschroevers/error-prone-classpath-fix branch January 29, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Venorcis Venorcis Venorcis approved these changes

Assignees
No one assigned
Labels
improvement
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @Venorcis @rickie