-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Error Prone -XepExcludedPaths
flag to be Windows-compatible
#927
Conversation
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Prior to these changes the provided pattern would never match on Windows, as Error Prone matches against file URIs, which in practice will always contain forward slashes, even on Windows.
1127e14
to
55637a7
Compare
Nice fix! Just rebased, will merge once 🟢 . |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Looks good. No mutations were possible for these changes. |
I updated the label, as this is a build improvement that doesn't impact users :) |
Haha had dinner so didn't do the merging 😬. But yeah makes sense. |
See #925 (comment):
-XepExcludedPaths:\Q${project.build.directory}${file.separator}\E.*
doesn't work because Error Prone matches against a path that's derived from a file's URI, which in practice will always contain forward slashes.Suggested commit message:
Testing:
rewrite-templating
annotation processor to also produce OpenRewrite recipes #925 I validated that these changes prevent Error Prone from flagging violations against OpenRewrite-generated recipes when running on Windows.git show a0b1f7091ee4f902f4abdcc9649fe0e902669948 -- error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/CollectorMutability.java | git apply -R
.