Skip to content

Commit

Permalink
Update Error Prone -XepExcludedPaths flag to be Windows-compatible
Browse files Browse the repository at this point in the history
Prior to these changes the provided pattern would never match on
Windows, as Error Prone matches against file URIs, which in practice
will always contain forward slashes, even on Windows.
  • Loading branch information
Stephan202 authored and rickie committed Dec 24, 2023
1 parent 1650b6b commit 55637a7
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1741,7 +1741,13 @@
avoid that, so we simply tell Error Prone
not to warn about generated code. -->
-XepDisableWarningsInGeneratedCode
-XepExcludedPaths:\Q${project.build.directory}${file.separator}\E.*
<!-- XXX: Ideally we'd match against
`\Q${project.build.directory}${file.separator}\E.*`,
but that approach doesn't work on Windows,
as Error Prone matches against a path that
always contains forward-slash path
separators. -->
-XepExcludedPaths:(?!.*/src/[^/]+/java/.*).*
<!-- We don't target Android. -->
-Xep:AndroidJdkLibsChecker:OFF
<!-- XXX: Enable this once we open-source
Expand Down

0 comments on commit 55637a7

Please sign in to comment.