Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade com.spotify.fmt:fmt-maven-plugin 2.20 -> 2.21.1 - abandoned #802

Closed
wants to merge 2 commits into from
Closed

Upgrade com.spotify.fmt:fmt-maven-plugin 2.20 -> 2.21.1 - abandoned #802

wants to merge 2 commits into from

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
com.spotify.fmt:fmt-maven-plugin build minor 2.20 -> 2.21.1

Release Notes

spotify/fmt-maven-plugin (com.spotify.fmt:fmt-maven-plugin)

v2.21.1

Compare Source

What's Changed

Full Changelog: spotify/fmt-maven-plugin@2.21...2.21.1

v2.21

What's Changed

New Contributors

Full Changelog: spotify/fmt-maven-plugin@2.19.0...2.21

  • If you want to rebase/retry this PR, check this box

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Sep 23, 2023 •
edited by Stephan202
Loading

Suggested commit message:

Upgrade fmt-maven-plugin 2.20 -> 2.21.1 (#802)

See:
- https://github.com/spotify/fmt-maven-plugin/releases/tag/2.21
- https://github.com/spotify/fmt-maven-plugin/releases/tag/2.21.1
- https://github.com/spotify/fmt-maven-plugin/compare/fmt-maven-plugin-2.20...2.21.1

@Stephan202 Stephan202 added this to the 0.14.0 milestone Sep 23, 2023
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Stephan202
Stephan202 approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformatted the code. (Already saw these new lines being introduced by the IDEA plugin.)

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssortedRules.java
Comment on lines 105 to 108
@AfterTemplate
@Nullable
T after(Iterator<T> iterator, T defaultValue) {
@Nullable T after(Iterator<T> iterator, T defaultValue) {
return Iterators.getNext(iterator, defaultValue);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts the changes in ff2ed6f, as a result of google/google-java-format#869.

@Picnic-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@Picnic-Bot Picnic-Bot changed the title Upgrade com.spotify.fmt:fmt-maven-plugin 2.20 -> 2.21.1 Upgrade com.spotify.fmt:fmt-maven-plugin 2.20 -> 2.21.1 - abandoned Sep 27, 2023
@Picnic-Bot
Copy link
Contributor Author

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@Stephan202 Stephan202 mentioned this pull request Sep 27, 2023
Merged
1 task
@Stephan202
Copy link
Member

Changes ported to replacement PR #804.

@Stephan202 Stephan202 closed this Sep 27, 2023
@Stephan202 Stephan202 deleted the renovate/com.spotify.fmt-fmt-maven-plugin-2.x branch September 27, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@rickie rickie Awaiting requested review from rickie

Assignees
No one assigned
Labels
dependencies
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Picnic-Bot @Stephan202