Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce additional Mockito Refaster rules #777

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Introduce additional Mockito Refaster rules #777

merged 1 commit into from
Oct 9, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Sep 3, 2023 •
edited
Loading

Suggested commit message:

Introduce additional Mockito Refaster rules (#777)

@Stephan202 Stephan202 added this to the 0.14.0 milestone Sep 3, 2023
@Stephan202 Stephan202 requested review from werli and rickie September 3, 2023 10:35
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie modified the milestones: 0.14.0, 0.15.0 Oct 4, 2023
@Stephan202 Stephan202 force-pushed the sschroevers/more-mockito-rules branch from dada0f6 to 54cb569 Compare October 4, 2023 16:24
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Venorcis
Venorcis approved these changes Oct 6, 2023
View reviewed changes
error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java

@AfterTemplate
Object after(InvocationOnMock invocation, int i) {
return invocation.getArgument(i);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to add this one, just to see this PR already open 😄🚀

@rickie rickie force-pushed the sschroevers/more-mockito-rules branch from 54cb569 to 2931c7d Compare October 9, 2023 07:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie merged commit c48db52 into master Oct 9, 2023
17 checks passed
@rickie rickie deleted the sschroevers/more-mockito-rules branch October 9, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@werli werli werli approved these changes

@Venorcis Venorcis Venorcis approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Stephan202 @Venorcis @werli @rickie